Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module roots #2319

Merged
merged 7 commits into from
May 22, 2024
Merged

Module roots #2319

merged 7 commits into from
May 22, 2024

Conversation

tsahee
Copy link
Contributor

@tsahee tsahee commented May 21, 2024

supports legacy module roots in:

  • a binary can look for moduleRoots in other places
  • sort-out docker for legacy moduleRoots

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label May 21, 2024
@tsahee
dockerfile: sort split-validator support
458669a 
nitro has legacy machines and config to check for these wasmModuleRots
nitro-validator has split-validation on
nitro-dev is based of validator and has latest as well
@tsahee tsahee marked this pull request as ready for review May 21, 2024 22:50
@tsahee tsahee requested a review from PlasmaPower May 21, 2024 23:49
PlasmaPower
PlasmaPower approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There's a crash in the block validator with missing module roots, but that's largely separate, so I think we should merge this now to minimize future merge conflicts.

@PlasmaPower PlasmaPower enabled auto-merge May 22, 2024 05:28
@PlasmaPower PlasmaPower merged commit 3cc94a3 into master May 22, 2024
10 checks passed
@PlasmaPower PlasmaPower deleted the module_roots branch May 22, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PlasmaPower PlasmaPower PlasmaPower approved these changes

Assignees
No one assigned
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsahee @PlasmaPower